Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrating captions #971

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: migrating captions #971

merged 1 commit into from
Sep 25, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

PR App RM-10929

🧰 Changes

Fixes migrating images with captions.

Recent PRs have been normalizing the use of src and url with the various image transformers. I misssed one 🤮

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review September 25, 2024 17:22
rafegoldberg
rafegoldberg approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused: I see how this might fix SRC/URL migration issues, but not so much the caption problem? That said, this change looks sound to me! 👌

@kellyjosephprice
Copy link
Collaborator Author

I'm a bit confused: I see how this might fix SRC/URL migration issues, but not so much the caption problem? That said, this change looks sound to me! 👌

Yea, poorly worded.

@kellyjosephprice kellyjosephprice merged commit afa40af into next Sep 25, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/migrating-captions branch September 25, 2024 17:54
rafegoldberg pushed a commit that referenced this pull request Sep 25, 2024
@semantic-release-bot
build(release): 🚀 v7.5.4 🦉
2d9fffc 
## Version 7.5.4

### 🛠 Fixes & Updates

* migrating captions ([#971](#971)) ([afa40af](afa40af))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@trishaprile trishaprile Awaiting requested review from trishaprile

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyjosephprice @rafegoldberg